-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sub ass style overrides always applied #4927
Comments
This commit will: - Change the subOverrideHandler Transformer in MPVController.mpvInit to return "no" when "Ignore ASS styles" is disabled - Change PrefSubViewController.xib to only enable the "Override level" slider when "Ignore ASS styles" is enabled - Add 20 to the horizontal location of the "Override level" label to indent this setting under the "Ignore ASS styles" setting This changes IINA to set the mpv option "sub-ass-override" to "no" when the setting for overriding styles in Advanced Substation Alpha subtitles is not enabled. This commit also indents the "Override level" setting to indicate it is a subordinate option and disables the slider if "Ignore ASS styles" is not enabled.
Does this mean when |
Likely because It is being set to
And IINA does not provide access to the However when working on this it seemed like We need to check in with @lhc70000 as he may want this fix to be held until the feature release beta as if I noticed this when checking Hebrew translations and noticed the text showing the setting was not localized. That caused me to take a close look at this feature. This issue shows why it is desirable to merge PR #4926. When setting |
It was set to I think when implementing this I was trying to minimize such discrepancies. When disabled, it's the default mpv behavior; when enabled, it's set to I agree that it's an issue to set it to With the default So, I'm not sure whether it's a bug because the help text says
which should be true (right?) So we have two choices
|
This is incorrect. There are multiple problems. IINA is not aligned with the
This allows a user to specify styles specifically for ASS subtitles. This matches up with
For the settings IINA provides
I'm pretty sure this:
Is a result of a
I started on changes to add Because Using a checkbox and a slider is all fine. But currently styles are being overriden with the checkbox unchecked. That is not how this The slider should be:
At least I think that is how this For sure lets not merge this for 1.3.5. Maybe we end up with |
I've entered I've removed this issue from the 1.3.5 release and changed the PR to be a draft. Seems like a correct UI representation of IINA's current behavior would not have a toggle and would just be a slider with I'm thinking wait until we hear from |
The
And of course there is now:
And the Thus I'm still thinking IINA should at some point provide a full implementation of this |
Maybe we can remove the checkbox and only use one slider with five levels: no, yes, scale, force, strip. We don't show user the level names to avoid confusion, instead we display some help text that changes with the slider value. For example (of course we need to come up with better descriptions):
|
There is another reason to eliminate the checkbox and just use a slider. We need to add support for secondary-sub-ass-override. I think the UI would be better with just two sliders and no checkboxes. I very much like the idea of help text that changes with the selection. I'm not in favor of eliminating the level names. Once a user understand what this does the level names are useful. We also could add a help button linked to the For this to make sense we have to also add support for at least some of the The fix for the |
System and IINA version:
Expected behavior:
When the setting
Ignore ASS styles
is not enabled style overrides are not applied.Actual behavior:
When the setting
Ignore ASS styles
is not enabled IINA sets the mpv sub-ass-override option toyes
causing style overrides to be applied. From the mpv manual entry for the sub-ass-override option:When the setting
Ignore ASS styles
is not enabled IINA should be settingsub-ass-override
tono
.Steps to reproduce:
Settings…
under theIINA
menuSubtitle
ASS Subtitles
section uncheck theIgnore ASS styles
settingOverride level
slider all the way to the leftAdvanced
Enable advanced settings
toggle button to be on (blue)Additional mpv options
section click on+
name
and replace it withsub-ass-style-overrides
value
and replace it withFontName=Wingdings
Ignore ASS styles
is not enabled the style override will be applied and the subtitles will look like the screenshot belowWith
Ignore ASS styles
disabled the styles in the subtitle file were still overridden:The subtitle file used for testing (with
.txt
added to make GitHub happy):big-buck-bunny.ass.txt
How often does this happen?
Every time.
The text was updated successfully, but these errors were encountered: