Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/ add feature to specify quote asset as order amount in pmm strategy #7040

Open
wants to merge 5 commits into
base: development
Choose a base branch
from

Conversation

zeeshanakram3
Copy link

No description provided.

@nikspz nikspz changed the base branch from master to development May 22, 2024 06:10
@cardosofede
Copy link
Contributor

@zeeshanakram3 hey thanks for the contribution. I approved the workflow but as it's a change in a core strategy you need to go through the governance process. Check the docs under the contributions section to understand it.
I think that the test might fail since you are adding new functionality without coverage, and also we are trying to move away from the v1 strategies and the v2 strategies are all using quote asset, so you might want to check that if that's what you are using.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants