-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporary build workaround no longer required #11896
base: master
Are you sure you want to change the base?
Conversation
The upx project itself already applied such a change in order to make its own CI work properly. Also, a new version of the default compilers obviated the change anyway.
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
jreiser is a new contributor to projects/upx. The PR must be approved by known contributors before it can be merged. The past contributors are: MykolaMykhno |
I cannot tell whether my additional email address jreiser@BitWagon.com has passed the CLA check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. This is no longer needed, as clang was bumped in oss-fuzz.
This pull request was approved yesterday by @maflcko but did not get applied in time for a build which failed this morning https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=66785#c16 . Why not? [Edit] The Actions page https://github.com/google/oss-fuzz/actions/runs/8940978935/job/24563455468?pr=11896 shows 5 successes (green checkmark icons adjacent to jobs) and 6 failures (red X icons on jobs). The failures all are
So this looks like inconsistent propagation of the pull request, because there were no changes elsewhere. |
A maintainer needs to merge it first. (I am not a maintainer here)
The failures are real. This happens because the patch is no longer applied. You can either apply the patch in the build script here (you can also use |
The upx project itself already applied such a change in order to make its own CI work properly. Also, a newer version of the default compilers obviated the change anyway.