Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: git/git
base: 7a01b444638a2704befcd4c24e1d441b818ae67b
Choose a base ref
...
head repository: git/git
compare: 60c4c425155c61a081cc035240ee649aa2cb2e37
Choose a head ref
  • 4 commits
  • 5 files changed
  • 1 contributor

Commits on Mar 7, 2024

  1. lockfile: report when rollback fails 

    We do not report to the caller when rolling back a lockfile fails, which
will be needed by the reftable compaction logic in a subsequent commit.
It also cannot really report on all errors because the function calls
`delete_tempfile()`, which doesn't return an error either.

Refactor the code so that both `delete_tempfile()` and
`rollback_lock_file()` return an error code.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
    @pks-t @gitster
    pks-t authored and gitster committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    4ae540d View commit details
    Browse the repository at this point in the history

  2. reftable/stack: register new tables as tempfiles 

    We do not register new tables which we're about to add to the stack with
the tempfile API. Those tables will thus not be deleted in case Git gets
killed.

Refactor the code to register tables as tempfiles.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
    @pks-t @gitster
    pks-t authored and gitster committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    1920d17 View commit details
    Browse the repository at this point in the history

  3. reftable/stack: register lockfiles during compaction 

    We do not register any of the locks we acquire when compacting the
reftable stack via our lockfiles interfaces. These locks will thus not
be released when Git gets killed.

Refactor the code to register locks as lockfiles.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
    @pks-t @gitster
    pks-t authored and gitster committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    3a60f6a View commit details
    Browse the repository at this point in the history

  4. reftable/stack: register compacted tables as tempfiles 

    We do not register tables resulting from stack compaction with the
tempfile API. Those tables will thus not be deleted in case Git gets
killed.

Refactor the code to register compacted tables as tempfiles.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
    @pks-t @gitster
    pks-t authored and gitster committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    60c4c42 View commit details
    Browse the repository at this point in the history