Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(hybridcloud) Remove deprecated tuple return method #71126

Merged
merged 2 commits into from
May 22, 2024

Conversation

markstory
Copy link
Member

Remove an RPC method that had a tuple return. The only call site will be removed in getsentry/getsentry#14014

Remove an RPC method that had a tuple return. The only call site will be
removed in getsentry/getsentry#14014
@markstory markstory requested a review from a team as a code owner May 17, 2024 18:59
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 17, 2024
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.90%. Comparing base (da4e986) to head (a13c5e1).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #71126      +/-   ##
==========================================
+ Coverage   77.88%   77.90%   +0.02%     
==========================================
  Files        6527     6525       -2     
  Lines      290836   290524     -312     
  Branches    50338    50257      -81     
==========================================
- Hits       226516   226340     -176     
+ Misses      58070    57936     -134     
+ Partials     6250     6248       -2     
Files Coverage Δ
src/sentry/services/hybrid_cloud/user/impl.py 83.50% <ø> (-0.25%) ⬇️
src/sentry/services/hybrid_cloud/user/service.py 85.98% <ø> (+0.39%) ⬆️

... and 22 files with indirect coverage changes

@markstory markstory merged commit 7dccbef into master May 22, 2024
49 checks passed
@markstory markstory deleted the chore-remove-deprecated-rpc branch May 22, 2024 18:01
@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants