-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generating backpressure dd events #71086
Conversation
What is the motivation for this? Does it tell us anything that the metric doesn't already? |
Hey @lynnagara there was some more detail in the original PR / ticket: https://getsentry.atlassian.net/browse/OPS-5392 This would enable us to do things like:
|
Here's an example time period where we experienced backpressure on May 6: And split: Some things that aren't clear:
Here is one ingest consumer lag graph of the same time: With events we can have discrete events that could include information from the backpressure system for more context. These can be overlaid on top of graphs: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #71086 +/- ##
==========================================
- Coverage 77.89% 77.89% -0.01%
==========================================
Files 6525 6525
Lines 290597 290601 +4
Branches 50276 50276
==========================================
- Hits 226375 226372 -3
- Misses 57975 57979 +4
- Partials 6247 6250 +3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Now that sentry supports Datadog events,
updating backpressure code to generate events as well (in addition to metrics).
Next steps