Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

out_calyptia: move debug payload to debug level. #8805

Merged
merged 1 commit into from
May 29, 2024
Merged

out_calyptia: move debug payload to debug level. #8805

merged 1 commit into from
May 29, 2024

Conversation

lecaros
Copy link
Contributor

@lecaros lecaros commented May 8, 2024

Moving the debug payload from info to debug level.

The output of this can result in half-way lines, which confuses the user.

Example 1 
[2024/05/07 21:11:41] [ warn] [output:calyptia:calyptia.2] http_status=422:
{"error":"zero metric values"}
[2024/05/07 21:11:41] [error] [output:calyptia:calyptia.2] could not deliver metrics
[2024/05/07 21:11:41] [ info] [output:calyptia:calyptia.2] debug payload:
2024-05-07T21:11:40.221389762Z fluentbit_uptime{pipeline_id="xxx",hostname="yyy"} = 5
...
2024-05-07T21:11:35.674983168Z fluentbit_output_retries_failed_total{pipeline_id="xxx",name="stdout.1"} = 0
2024-05-07T21:11:35.674983168Z fluentbit_output_dropped_records_total{pipeline_id="xxx",name="stdout.1"} = 0
2024-05-07T21:11:35.674983168Z fluentbit_output_retried_records_total{pipeline_id="xxx",name="stdout.1"} = 0
2024-05-07T21:11:35.675263704Z fluentbit_output_proc_records_total{pipeline_id="xxx",name="calyptia.2"} = 0
2024-05-07T21:11:35.675263704Z fluentbit_output_proc_bytes_total{pipeline_id="xxx",name="calyptia.2"} = 0
2024-05-07T21:11:35.675263704Z fluentbit_output_errors_total{pipeline_id="xxx",name="calyptia
Example 2 
[2024/05/04 15:40:23] [ warn] [output:calyptia:calyptia.1] http_status=422:
{"error":"zero metric values"}
[2024/05/04 15:40:23] [error] [output:calyptia:calyptia.1] could not deliver metrics
[2024/05/04 15:40:23] [ info] [output:calyptia:calyptia.1] debug payload:
...
2024-05-04T15:40:17.432402887Z fluentbit_output_retried_records_total{pipeline_id="yyy",name="calyptia.1"} = 0
2024-05-04T15:40:22.217258412Z fluentbit_process_start_time_seconds{pipeline_id="yyy",hostname="xxx"} = 1714837217
2024-05-04T15:40:22.217258412Z fluentbit_build_info{pipeline_id="yyy",hostname="xxx",,os="linux"} = 1714837217
2024-05-04T15:40:22.217258412Z fluent

This should only be printed if debug is enabled.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@lecaros
out_calyptia: move debug payload to debug level.
0b617b2 
Signed-off-by: lecaros <lecaros@calyptia.com>
@edsiper
Copy link
Member

edsiper commented May 15, 2024

@pwhelan pls review

pwhelan
pwhelan approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@pwhelan pwhelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edsiper edsiper added this to the Fluent Bit v3.0.7 milestone May 29, 2024
@edsiper edsiper merged commit 4db79b4 into master May 29, 2024
47 checks passed
@edsiper edsiper deleted the move-debug-payload-to-debug-level branch May 29, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwhelan pwhelan pwhelan approved these changes

@edsiper edsiper Awaiting requested review from edsiper edsiper is a code owner

@leonardo-albertovich leonardo-albertovich Awaiting requested review from leonardo-albertovich leonardo-albertovich is a code owner

@fujimotos fujimotos Awaiting requested review from fujimotos fujimotos is a code owner

@koleini koleini Awaiting requested review from koleini koleini is a code owner

Assignees

@pwhelan pwhelan

Labels
None yet
Projects
None yet
Milestone
Fluent Bit v3.0.7
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lecaros @edsiper @pwhelan