Http badbots #1242
Http badbots #1242
Conversation
|
So is this one extension to previously contributed handling of 'known' within config files? (and somewhat of a fix for #875)? |
fail2ban/client/configreader.py
Outdated
| @@ -285,8 +285,10 @@ def getOptions(self, pOpts): | |||
|
|
|||
| if self.has_section("Init"): | |||
| for opt in self.options("Init"): | |||
| v = self.get("Init", opt) | |||
There was a problem hiding this comment.
please use more descriptive names, e.g. "init_opt_value" here
There was a problem hiding this comment.
v will be use in 2 lines below. Please let such easy code fixing not as a hand brake for such PR's again. I mean you have apparently no problem with the opt above...
There was a problem hiding this comment.
OK, I will just do it myself after the merge if that is so much effort
On November 2, 2015 5:32:07 PM EST, "Serg G. Brester" notifications@github.com wrote:
@@ -285,8 +285,10 @@ def getOptions(self, pOpts):
if self.has_section("Init"): for opt in self.options("Init"):
v = self.get("Init", opt)
vwill be use in 2 lines below. Please let such easy code fixing not
as a hand brake for such PR's again. I mean you have apparently no
problem with theoptabove...
Reply to this email directly or view it on GitHub:
https://github.com/fail2ban/fail2ban/pull/1242/files#r43693041
|
amend b0f3dfc |
|
@sebres I guess this one needs master merged to account for already introduced |
|
And I fear, I will need to do a little fix inside... |
fe8a9d2
to
9d77fb2
Compare
|
should this be let RiP @sebres ? |
…dbots) common filter to ban bad-bot hosts for apache/nginx (catches known spambots and software alike), see fail2bangh-712;
|
Rebased and resolved conflicts (all changes on known-mimic has seemed being already implemented in other branches, so only filter and changelog going here). I must think about it a bit, let us safe this firstly for a while (I'll block it right now). |
new apache/nginx jail and filter http-badbots - (previously apache-badbots) common filter to ban bad-bot hosts for apache/nginx (catches known spambots and software alike);
See gh-712
Based on #1241 because init definition of this filter can be extended using own regex, example:
or