Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Save feature deletes user's entry after "MAPXX" #820

Open
dftf-stu opened this issue Jan 25, 2022 · 3 comments
Open

[Bug] Save feature deletes user's entry after "MAPXX" #820

dftf-stu opened this issue Jan 25, 2022 · 3 comments

Comments

@dftf-stu
Copy link

Background

Version of Crispy Doom: 5.10.3
Operating System: Windows 10 21H2 (64-bit; non-ARM)
Game: PLUTONIA
Any loaded WADs and mods (please include full command line):
crispy-doom.exe -IWAD PLUTONIA.wad -MERGE -FILE FDDM0121.wad FDP_0121.wad -DEH FDDM0121.deh -SAVEDIR SAVES\FDID_PLU

Bug description

Steps to reproduce:

  1. During a game press ESCAPE (or your Menu key) then go to Save Game
  2. Pick any slot, and type some custom text after the default entry (for example, after "MAP02" I would type "Current Position" which names the entry "MAP02 Current Position" )
  3. After saving, the gameplay resumes
  4. Go back into the Menu, then again to "Save Game"
  5. Select the same save-slot you used above, then press ENTER
  6. Your custom text gets erased, and it goes back to "MAPXX"

Expected behaviour:

If the user has entered additional text after the MAPXX reference, this text should not get erased, surely?

Workaround?

As a workaround, you can use different text at the beginning: for example, instead of "MAP02" change it to "LEV02".

Screenshots:

CrispyDOOM_SaveNameIssue1
Above: the default name for the save on the second map I am on is "MAP02". I have typed "Current Position" after this.

CrispyDOOM_SaveNameIssue2
Above: after saving, go back into the Menu then to "Save Game". The custom text I added has been retained...

CrispyDOOM_SaveNameIssue3
Above: ...however, the moment I press ENTER to overwrite the save, it deletes all text after "MAP02".
@fabiangreffrath
Copy link
Owner

I wouldn't say it's a bug but rather a feature that got in your way. Things get interesting if you save a game in a map loaded from a PWAD. Then the PWAD name will be appended to the map name in parentheses, e.g. "MAP01 (icarus.wad)". However, this means that i cannot even say that a savegame name may not get overridden if there is some additional text after the map identifier. So, currently my best bet us that if the savegame name starts with a map identifier, then it's free to be overridden.

@dftf-stu
Copy link
Author

[...] the PWAD name will be appended to the map name in parentheses, e.g. "MAP01 (icarus.wad)"

So in my example, shouldn't my save name default to "MAP02 (FDDM0121.wad)" or "MAP02 (FDP_0121.wad)"? (I'm not sure with multiple PWADs whether it would go by the first or last wad in the command-line to derive the name from?).

Or does this only work when only a single PWAD file is used, not multiple?

@fabiangreffrath
Copy link
Owner

It appends the name of the PWAD the map is loaded from. If you load a texture or music pack this won't make a difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fabiangreffrath @dftf-stu