Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/zip2bodyfile #27

Merged
merged 15 commits into from
Jun 10, 2024
Merged

Feature/zip2bodyfile #27

merged 15 commits into from
Jun 10, 2024

Conversation

janstarke
Copy link
Member

add zip2bodyfile

@janstarke janstarke added the enhancement New feature or request label Feb 27, 2024
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.85%. Comparing base (e978e71) to head (9bb7369).

Current head 9bb7369 differs from pull request most recent head 5351569

Please upload reports for the commit 5351569 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #27      +/-   ##
===========================================
+ Coverage    33.68%   33.85%   +0.17%     
===========================================
  Files           36       36              
  Lines         1140     1143       +3     
===========================================
+ Hits           384      387       +3     
  Misses         756      756              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Explie Explie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janstarke I'm a little confused why the displayed modified timestamps on windows and unix archive managers are shifted for 9 hours in comparison to zip2bodyfile.

zip2bodyfile

@janstarke
Copy link
Member Author

janstarke commented Feb 29, 2024

Can you recheck this with another tool? Times are matching on my system, when using unzip and 7z

grafik

However, zip seems to be using local time instead of UTC. Hmm....

@janstarke
Copy link
Member Author

I added an integration test. Could you please provide another one which fails on your test data?

@Explie
Copy link
Member

Explie commented Feb 29, 2024

I added the failing test and test data.
What is making me curious is that the simplest change to the files within the ZIP archive leads to zip2bodyfile detecting the "correct" timestamps. Also I was not able to manually create a failing ZIP archive but the old one I had still reproduces the error.

@janstarke janstarke self-assigned this May 24, 2024
@janstarke janstarke merged commit 5351569 into develop Jun 10, 2024
2 checks passed
@janstarke janstarke deleted the feature/zip2bodyfile branch June 13, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants