-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dbeaver/dbeaver#18437 Support of InterSystems IRIS VIEW definition #33183
base: devel
Are you sure you want to change the base?
Conversation
To implement getViewDDL I added a plugin for InterSystems IRIS
Thank you for contribution. We will review it and let you know if any corrections are needed. |
@NotNull DBRProgressMonitor monitor, | ||
@NotNull GenericView view, | ||
@NotNull Map<String, Object> options) throws DBException { | ||
String sqlStatement = "SELECT View_Definition " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the Intersystem also have the table definition? And procedure? To create more methods about definitions reading. (getTableDDL, getProcedureDDL)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's possible to get procedure definition, list of triggers, source code for triggers. Do you think it makes sense to do this as part of this pull request? If yes -- I'll do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can be just definitions. Triggers are also welcome, but you can do them in a separate PR if you want.
To implement getViewDDL I added a plugin for InterSystems IRIS
./build.sh was successful.