Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The base64 representation of the ID is clunky to work with #11

Open
ckreibich opened this issue Jun 14, 2019 · 1 comment
Open

The base64 representation of the ID is clunky to work with #11

ckreibich opened this issue Jun 14, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@ckreibich
Copy link
Member

The standard rendering of the ID (eg 1:ZEYOYMeyZNQC9DAdgsBZCtiTKqw=) is not only not very nice to look at, but can break standard string handling in SIEM pipelines and other tools (so you need to add quotes, for example). A reduced character set would work better here, at the expense of a slightly longer string.

I'm considering moving to something like base58 as a default for version 2 of the ID. Thoughts welcome.
@ckreibich ckreibich added the enhancement New feature or request label Jun 14, 2019
@sfd
Copy link

sfd commented Jun 19, 2019

So 20 bytes of SHA1 becomes 28 bytes in Base64, saving 12 bytes compared to hexadecimal at 40 bytes, although with quotes you get to 30. How long would it be in Base58?
Is it worth it? Most databases would compress the field content anyway?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sfd @ckreibich