vmtests: deduplicating code using LVH library for arm64 support #2333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
340954b
to
cc43ac5
Compare
f32029d
to
b42b9b2
Compare
90eb6d0
to
36c8c7d
Compare
a261658
to
4bf7274
Compare
4bf7274
to
248fe24
Compare
|
I wouldn't mind a review @kkourt so that I can rebase afterward and make sure I don't rebase twice :) |
Deduplicate some codes shared between vmtests and LVH: - inject LVH runner.RunConf into vmtests RunConf and reuse existing LVH configuration fields. - use LVH runner.BuildQemuArgs along with custom vmtests logic. - removes the support for HVF, we would need to put it in LVH to get this again but I don't think this is used nowadays. This is mainly so that we benefit from the arm64 support as LVH was recently updated to support it. Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
Previously the fetch-data was defaulting to root-images:latest that is more than a year old now (!) but most importantly, not multi-arch as this new tag. Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
248fe24
to
44240da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deduplicate some codes shared between vmtests and LVH:
This is mainly so that we benefit from the arm64 support as LVH was recently updated to support it.