Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/loader reconciliation 5 #32605

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

dylandreimerink
Copy link
Member

WIP

dylandreimerink and others added 10 commits May 17, 2024 14:50
Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>
- Remove datapath.Loader and only use loader/types.Loader
- Add LoaderContext for passing device and address data to the loader.
  In the future this can contain other data queried from the agent.
- Query for node addresses in the orchestrator instead of loader and
  pass them as part of LoaderContext.
- Add rate limiting so we don't reinit twice due to propagation delay
  to Table[NodeAddress]

Signed-off-by: Jussi Maki <jussi@isovalent.com>
Signed-off-by: Jussi Maki <jussi@isovalent.com>
Retry failed reinitialization after 10 second delay.

Signed-off-by: Jussi Maki <jussi@isovalent.com>
If we pass the whole LocalNode we will reinitialize on irrelevant
changes.

Signed-off-by: Jussi Maki <jussi@isovalent.com>
- drop useless ipsecMu
- pass LoaderContext in template cache update to recompute hash based on it
- also collect the fallback node addresses

Signed-off-by: Jussi Maki <jussi@isovalent.com>
This mechanism proved out to make the use of the Table[NodeAddress]
inconvenient. Reimplement the fallback as a computation around a set
of node addresses instead.

It also was not useful to have the fallback addresses from non-selected
devices.

Signed-off-by: Jussi Maki <jussi@isovalent.com>
The Chdir() done by Daemon.init was racing with the loader causing
just compiled object files to not be found. Change the Chdir() in
initEnv() to switch to StateDir directly and remove the Chdir() from
Daemon.init.

Signed-off-by: Jussi Maki <jussi@isovalent.com>
Signed-off-by: Jussi Maki <jussi@isovalent.com>
Signed-off-by: Jussi Maki <jussi@isovalent.com>
@dylandreimerink dylandreimerink added the dont-merge/preview-only Only for preview or testing, don't merge it. label May 17, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 17, 2024
@github-actions github-actions bot added the sig/policy Impacts whether traffic is allowed or denied based on user-defined policies. label May 17, 2024
Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. dont-merge/preview-only Only for preview or testing, don't merge it. sig/policy Impacts whether traffic is allowed or denied based on user-defined policies.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants