-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup using wrong color palette #1658
Comments
I opened the PR to fix this issue: PR |
@fabiangreffrath If it is not much trouble, can you review my PR? This is my first time opening a PR in Github, so I may have missed smth. |
It's not much trouble, you seem to have done everything alright. That is, technically your Pr is flawless, it is just that I cannot judge myself if using EGA colors is "more correct" than using CGA colors. |
Hmm, got it. I guess then only @fragglet can say for sure if this is a valid alteration. Looking the code commits, it seems he was the one who created the palette some 17 years ago. |
Background
Version of Chocolate Doom: 3.0.1
Operating System and version: any
Game: (Doom/Heretic/Hexen/Strife/other) Setup program
Any loaded WADs and mods (please include full command line): no
Bug description
Observed behavior:
The Setup program is using the CGA color palette, instead of using the EGA color palette. For instance, the code uses #00A800 for green, when the right EGA green color is #00AA00. The same happens for the remaining colors.
Expected behavior:
Use the EGA color palette.
The text was updated successfully, but these errors were encountered: