Allow local dynamodb to be installed on another host than localhost #8965
+18
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8965 +/- ##
=======================================
Coverage 77.80% 77.81%
=======================================
Files 150 150
Lines 18680 18688 +8
Branches 3192 3193 +1
=======================================
+ Hits 14534 14542 +8
Misses 3854 3854
Partials 292 292
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Nusnus
reviewed
Apr 14, 2024
|
The docker-docs failure is not related btw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Before submitting this pull request, please review our contributing
guidelines.
Description
The previous version of dynamodb backend only allowed to have local dynamodb on your local dev machine. I changed it so that you can have local dynamodb running on an different machine and use an ip address instead of localhost:8000 . I use 127.0.0.1 as ip address in the unit test but it works with any ip address.