Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New installed app doesn't appear in the proxies apps list #1432

Open
NotMainstream opened this issue May 10, 2024 · 3 comments
Open

New installed app doesn't appear in the proxies apps list #1432

NotMainstream opened this issue May 10, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@NotMainstream
Copy link

I have installed a gps app named AllTrails. I received a notification from Rethink to allow or block internet access and I allowed it. Then I went in to the proxy settings to add the app to the VPN profile but the app doesn't appear at all in the list. I then went to check the logs and I could see internet traffic from that app and the name and icon was detected correctly but still I cannot find the app in the app list of the VPN profile. Maybe it would be easier to add a 3rd option in the app access notification to allow and add it to one of the VPN profiles.

@ignoramous ignoramous added the bug Something isn't working label May 11, 2024
@hussainmohd-a
Copy link
Collaborator

hussainmohd-a commented May 11, 2024

@NotMainstream, Could you please provide screenshots of the following:

  1. Apps screen.
  2. App selection screen within the VPN profile.
  3. Network logs screen.
  4. Rethink app version.

Also, does the refresh icon on the app selection screen doesn't help?

@ThreeDeeJay
Copy link

ThreeDeeJay commented May 13, 2024

I've also noticed this.
Usually when I install a new app, first I gotta refresh the main apps list (in case it wasn't detected/added already), wait about a full minute and then the proxy apps list refresh button will find the new app because refreshing it right away won't do anything even if I spam it, or just show it for a split second then hide it again till I refresh after a minute 🤔

My guess is that RDNS seems to use different app lists for rules and proxies that can desync when packages are added (or removed) so perhaps it should just merge them and use a single list (I'd love to be able too add an app to a proxy via the main app rules menu, but being able to select multiple apps from the proxy's list is also handy).

Also, I think apps that use app lists usually have broadcast receivers to detect package changes like these, which I noticed ReThink doesn't have:
android.intent.action.PACKAGE_ADDED
android.intent.action.PACKAGE_REPLACED
android.intent.action.PACKAGE_REMOVED
android.intent.action.PACKAGE_FULLY_REMOVED

@ignoramous
Copy link
Collaborator

ignoramous commented May 13, 2024

Also, I think apps that use app lists usually have broadcast receivers to detect package changes like these, which I noticed ReThink doesn't have:

We removed listening on those broadcasts because it caused battery drain for reasons that escaped us at the time. While the installed apps list is auto-refreshed every 3 hours, Rethink can also track new app installs "just in time" when a network requests comes in and it couldn't identify which app it was from (most likely means it was a new install).

My guess is that RDNS seems to use different app lists for rules and proxies that can desync when packages are added (or removed)

Yes, the in-memory caches + database tables are separate for firewall rules and proxy mapping rules, but that's more of a sqlite limitation (no "foreign key" support). We could use a singular database table but that is also not without complications. Desync between these tables/caches can happen but "refresh" should fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants