-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Master channel #6442
Draft
Paul-Licameli
wants to merge
54
commits into
audacity:master
Choose a base branch
from
Paul-Licameli:master-channel
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Master channel #6442
+1,807
−1,320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paul-Licameli
force-pushed
the
master-channel
branch
from
May 16, 2024 13:32
e3cab12
to
4cfb930
Compare
Paul-Licameli
force-pushed
the
master-channel
branch
3 times, most recently
from
May 24, 2024 16:22
d0671f7
to
9fadef3
Compare
Paul-Licameli
force-pushed
the
master-channel
branch
from
May 29, 2024 10:22
9fadef3
to
6718d2d
Compare
Updated the draft in progress today. It is still incomplete. |
Paul-Licameli
force-pushed
the
master-channel
branch
6 times, most recently
from
June 1, 2024 00:42
56f20ce
to
aa52b52
Compare
... The UI will still be present, but won't work
... maybe changing how non-LTI stereo effects (reverbs?) apply to mono tracks
... Also possible slight change in graphical meter level as explained in comments
... because that atomic might otherwise change
... the other playback policy subclasses (scrub, cut preview, looping) were not used for recording; and recording never went backwards
... Process both pieces of the intermediate result first (when it is not contiguous), before doing any of the shifting of samples. This bug might have happened only on some passes of TransformPlayBuffers.
... track states do not yet vary independently, but this prepares for a better treatment of differing effect latencies on tracks.
... and can be done before the update of the time queue, so long as the flushing of the ring buffers is later.
... letting playback states and mixers progress independently when the non-destructive effect latencies differ; and flushing only once. RingBuffer::Excess was needed transitionally, but is now unused. Maybe it will find another use again.
Paul-Licameli
force-pushed
the
master-channel
branch
from
June 2, 2024 17:17
5f99e5e
to
edc3d54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #6346
Resolves: #6507
Resolves: #6519
Resolves: #3651
Resolves: #6536
Alternative implementation of changes in AudioIO.cpp that will be compatible with per-track meters.
Also fixing:
QA:
(short description of the changes and the motivation to make the changes)
Recommended: