Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow building the tests without using conan #5870

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

allow building the tests without using conan #5870

wants to merge 1 commit into from
+4 −7

Conversation

christian-heusel
Copy link
Contributor

Resolves: #5841

This change allows to build the tests even though conan is not used.

  • I signed CLA
  • The title of the pull request describes an issue it addresses
  • If changes are extensive, then there is a sequence of easily reviewable commits
  • Each commit's message describes its purpose and effects
  • There are no behavior changes unnecessary for the stated purpose of the PR

Recommended:

  • Each commit compiles and runs on my machine without known undesirable changes of behavior

Related to #5771
cc @matoro since they initially wrote the patch

@crsib
Copy link
Contributor

crsib commented Jan 17, 2024

I expect this pull request to break the Build Audacity Linux Packages job. It is not run for PRs, only for branches, so this may be overlooked here.

@matoro
Copy link

matoro commented Jan 17, 2024

I expect this pull request to break the Build Audacity Linux Packages job. It is not run for PRs, only for branches, so this may be overlooked here.

This should be fixed by explicitly adding -Daudacity_conan_enabled=on to the job definition right?

@crsib
Copy link
Contributor

crsib commented Jan 17, 2024

This should be fixed by explicitly adding -Daudacity_conan_enabled=on to the job definition right?

-Daudacity_conan_enabled=off would be a fix, but not in the job, rather in the scripts it invokes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@christian-heusel @crsib @matoro