Attack of the fifty foot jellyfish!!! #5779
Open
+2,765
−1,893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8035a24
to
792c074
Compare
|
Updated -- I did some important work on the problem of per-track metering. Try it out again, with multiple, different stereo tracks, and observe that the goniometers display the correct per-track output, not the master output. Also vary the gain and pan sliders during play and observe how the meters respond. The work on internals to make this happen is serious work that should be merged to master, even if the display code is not. |
ee55b8a
to
c4d916a
Compare
c4d916a
to
dbd1b3f
Compare
... The real work happens only in AILAProcess which is still not called without the experimental flag turned on.
... see also f509d9c where GetMaxPeak became unused
... also consistency of signatures with the pure virtuals of MeterPanelBase
... Don't emit start events until success is known. Only ProjectAudioManager cared, and anyway ignored start events.
... Control areas are narrower, for WaveTrack. For other kinds of tracks, which don't have meters, the control areas are now wider.
c8cbf29
to
47244ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oh no! That four-year-old laboratory experiment that was long left for dead has REVIVED!
(Especially for you at your request to see it again, @petersampsonaudacity)
Recommended: