Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to specify (multiple) locations in Preferences during Plugin/Effects scan #6156

Closed
ianalarina opened this issue Mar 21, 2024 · 6 comments · Fixed by #6203
Closed
Assignees
Labels
Enhancement Request Or feature requests. Open-ended requests are better suited for discussions.
Milestone

Comments

@ianalarina
Copy link

Your idea

Add a new option in Effects preferences to specify custom plugin search path

Problem to be solved

At the moment, Audacity just reads from one location, which can be very problematic for those who like to keep effects on different drives, or when apps install effects in non-standard places

Prior art

No response

Additional context

No response

@ianalarina ianalarina added the Enhancement Request Or feature requests. Open-ended requests are better suited for discussions. label Mar 21, 2024
@ianalarina ianalarina added this to the Audacity 3.5 milestone Mar 21, 2024
@vsverchinsky vsverchinsky mentioned this issue Apr 2, 2024
6 tasks
@DavidBailes
Copy link
Collaborator

@vsverchinsky . There's a problem with the tab order.
image

If the "add new location" for the VST plugins is the focus, then if a user presses Tab, then the "add new location" button for the VST3 plugins becomes the focus, rather than the text box. This is a confusing reading order for users of screen readers - and it looks pretty odd as well.

@LWinterberg LWinterberg modified the milestones: Audacity 3.5, Audacity 3.6 Apr 4, 2024
@dozzzzer dozzzzer self-assigned this Apr 15, 2024
@dozzzzer
Copy link
Contributor

@vsverchinsky

When submitting the new plugin locations, then removing one of them and clicking OK button, Audacity crashes:

2024-04-23_19-04-00.mp4

After adding a plugin location for LADSPA, then for LV2 and then clicking the Remove button for LV2, the previously added LADSPA location is deleted instead:

2024-04-23_18-55-10.mp4

When adding new plugin locations, the bottom of the screen gets squashed:

2024-04-23_18-58-27.mp4

@dozzzzer
Copy link
Contributor

@vsverchinsky If more than one directory is added for the same plugin family, the new text boxes are put on top of the rest, taking away all available space with each newly added line:

image image

@dozzzzer
Copy link
Contributor

dozzzzer commented May 17, 2024

@vsverchinsky

Windows:

  • I provided 4 custom locations, one per family (LADSPA, LV2, VST, VST3); Only 2 of those directories - VST and VST3 - had files in them, the rest were empty. Then I closed the Preferences windows by clicking OK and then tried to run Rescan in the Plugin Manager. Result: a crash
2024-05-17_17-16-53.mp4

macOS:

  • I entered and saved new custom locations for LV2, LADSPA, VST, and VST3, with plugin files in each of them. Then I ran Rescan, and as a result, only in the LADSPA, LV2 and VST3 directories, the plugins were found. The plugins in the custom VST directory were not discovered during the rescan.

@dozzzzer
Copy link
Contributor

@vsverchinsky one of the previously reported issues remains unfixed: on macOS, a custom VST path is still being ignored and the plugins in it aren't found.

@dozzzzer
Copy link
Contributor

Tested. All previously reported problems have been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Request Or feature requests. Open-ended requests are better suited for discussions.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants