Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(deps): enable and fix whitespace linter #6723

Closed
wants to merge 1 commit into from
Closed

ci(deps): enable and fix whitespace linter #6723

wants to merge 1 commit into from

Conversation

mmorel-35
Copy link
Contributor

Description

enable and fix whitespace linter

@knqyf263
Copy link
Collaborator

Some people prefer having a whitespace at the beginning of functions.

@mmorel-35
Copy link
Contributor Author

I don't see any option for that on whitespace (https://golangci-lint.run/usage/linters/#whitespace)
Would gofmt or gofumpt be able to ensure that ?

@knqyf263
Copy link
Collaborator

This option seems to make sense to me. In other cases, whitespace is not necessary.

    # Enforces newlines (or comments) after every multi-line function signature.
    # Default: false
    multi-func: true

@mmorel-35 mmorel-35 marked this pull request as draft May 20, 2024 07:18
@mmorel-35
ci(deps): enable and fix whitespace linter
20dd8de 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 closed this May 29, 2024
@mmorel-35 mmorel-35 deleted the fix/whitespace branch May 29, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chen-keinan chen-keinan Awaiting requested review from chen-keinan chen-keinan is a code owner

@simar7 simar7 Awaiting requested review from simar7 simar7 is a code owner

@nikpivkin nikpivkin Awaiting requested review from nikpivkin nikpivkin is a code owner

@knqyf263 knqyf263 Awaiting requested review from knqyf263 knqyf263 is a code owner

@DmitriyLewen DmitriyLewen Awaiting requested review from DmitriyLewen DmitriyLewen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mmorel-35 @knqyf263