fix:kubectl discovery #543
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the call to kubectl would fail as it was passed as a single string. The output parsing has also been simplified using the json output of the command.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Also include relevant motivation and context. List any dependencies that are required for this change.
The kubectl discovery is not functional as the whole command is passed as a single string and thus cannot work with
subprocess.check_output. This merge request fixes that and simplifies the version parsing as well.Contribution Guidelines
Please Read through the Contribution Guidelines.
Fixed Issues
Please mention any issues fixed in the PR by referencing it properly in the commit message.
As per the convention, use appropriate keywords such as
fixes,closes,resolvesto automatically refer the issue.Please consult official github documentation for details.
Fixes #534
"BEFORE" and "AFTER" output
To verify that the change works as desired, please include an output of terminal before and after the changes under headings "BEFORE" and "AFTER".
BEFORE
Any Terminal Output Before Changes.
2023-10-14 17:15:45,325 DEBUG kube_hunter.modules.discovery.kubectl Could not find kubectl clientAFTER
2023-10-14 17:35:55,474 DEBUG kube_hunter.modules.discovery.kubectl Found kubectl client: v1.28.2Contribution checklist
Notes
Please mention if you have not checked any of the above boxes.
kubectl is required for the test to pass