[SPARK-48294][SQL][3.5] Handle lowercase in nestedTypeMissingElementTypeError #46643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What changes were proposed in this pull request? Handle lowercase values inside of nestTypeMissingElementTypeError to prevent match errors. ### Why are the changes needed? The previous match error was not user-friendly. Now it gives an actionable `INCOMPLETE_TYPE_DEFINITION` error. ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? Newly added tests pass. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#46623 from michaelzhan-db/SPARK-48294. Authored-by: Michael Zhang <m.zhang@databricks.com> Signed-off-by: Gengliang Wang <gengliang@apache.org> (cherry picked from commit 59f88c3)
4cecf93
to
c6dc72f
Compare
gengliangwang
approved these changes
May 17, 2024
|
Thanks, merging to branch-3.5 |
gengliangwang
pushed a commit
that referenced
this pull request
May 17, 2024
…ypeError ### What changes were proposed in this pull request? Backport of #46623. Handle lowercase values inside of nestTypeMissingElementTypeError to prevent match errors. ### Why are the changes needed? The previous match error was not user-friendly. Now it gives an actionable `INCOMPLETE_TYPE_DEFINITION` error. ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? Newly added tests pass. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #46643 from michaelzhan-db/SPARK-48294-3.5. Authored-by: Michael Zhang <m.zhang@databricks.com> Signed-off-by: Gengliang Wang <gengliang@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Backport of #46623.
Handle lowercase values inside of nestTypeMissingElementTypeError to prevent match errors.
Why are the changes needed?
The previous match error was not user-friendly. Now it gives an actionable
INCOMPLETE_TYPE_DEFINITIONerror.Does this PR introduce any user-facing change?
N/A
How was this patch tested?
Newly added tests pass.
Was this patch authored or co-authored using generative AI tooling?
No.