-
Notifications
You must be signed in to change notification settings - Fork 877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature]Support grafana charts for Prometheus #1658
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Logic <zqr10159@dromara.org>
…afana # Conflicts: # web-app/src/app/routes/monitor/monitor.module.ts
@tomsun28 I resolved conflicts and test errors ,please help review them. |
grafana/src/main/java/org/dromara/hertzbeat/grafana/config/GrafanaInit.java
Outdated
Show resolved
Hide resolved
grafana/src/main/java/org/dromara/hertzbeat/grafana/config/GrafanaInit.java
Outdated
Show resolved
Hide resolved
…afana # Conflicts: # common/src/main/java/org/apache/hertzbeat/common/entity/manager/Monitor.java # web-app/src/app/pojo/Monitor.ts # web-app/src/app/routes/monitor/monitor.module.ts
…eature#grafana # Conflicts: # common/src/main/java/org/apache/hertzbeat/common/entity/manager/Monitor.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has checked 2042 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
871 | 5 | 1166 | 0 |
Click to see the invalid file list
- common/src/main/java/org/apache/hertzbeat/common/entity/grafana/Dashboard.java
- common/src/main/java/org/apache/hertzbeat/common/entity/grafana/Grafana.java
- common/src/main/java/org/apache/hertzbeat/common/entity/grafana/ServiceAccount.java
- common/src/main/java/org/apache/hertzbeat/common/entity/grafana/ServiceToken.java
- web-app/src/app/pojo/Grafana.ts
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
common/src/main/java/org/apache/hertzbeat/common/entity/grafana/Dashboard.java
Show resolved
Hide resolved
common/src/main/java/org/apache/hertzbeat/common/entity/grafana/Grafana.java
Show resolved
Hide resolved
common/src/main/java/org/apache/hertzbeat/common/entity/grafana/ServiceAccount.java
Show resolved
Hide resolved
common/src/main/java/org/apache/hertzbeat/common/entity/grafana/ServiceToken.java
Show resolved
Hide resolved
import java.io.IOException; | ||
import java.nio.charset.StandardCharsets; | ||
|
||
import static org.apache.hertzbeat.common.constants.CommonConstants.FAIL_CODE; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please merge the master branch code and configure checkstyle according to this; maybe the code style detection will fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've discussed not merging it for the time being, and will merge this pr as a new feature after an official stable release.
What's changed?
Checklist
Add or update API