-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update maroto to v2.0.0 #1458
Comments
Hi @johnfercher !! This is a great initiative :) |
Thanks for the kind words, kubescape is awesome too. I will start this update soon. |
Hey @johnfercher, question for you. Does your company use kubescape? |
@johnfercher @alegrey91 I want to work on this issue. |
Hi @ankur0904, @johnfercher is already working on it. |
I see the version was bumped to v1 and not to v2 |
@dwertent Should I go for updating the version to v2? |
I think this was before opening this issue. @johnfercher correct me if I'm wrong. |
|
@johnfercher Where I have had the opportunity to have a chat with you? |
@johnfercher would you like to take care of this issue? |
Overview
Hello, I'm the creator of johnfercher/maroto and I see that you use the old version of maroto to generate a report in your project. I would like to purpose to use kubescape as a pilot to maroto v2. The project just reached the first beta version (after 42 alpha versions). The v2 is easier than v1, runs twice as fast as v1, allows unit tests and have a bunch of new features.
Problem
Solution
I would refactor the current code to use the v2, keeping the exactly same PDF structure that is generated today. I will create unit tests to warrant that the PDF is correct and I will provide benchmarks of the time execution of the report.
Alternatives
Additional context
I will also provide support to your project, helping with any issues and even adding features to maroto v2 to meet kubescape need.
The text was updated successfully, but these errors were encountered: