Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Feat/add financial year formatting to invoices #4564

Open
wants to merge 30 commits into
base: main
Choose a base branch
from

Conversation

chinmaypurav
Copy link

@chinmaypurav chinmaypurav commented Jan 14, 2024

Description

A clear and concise description of what this pull request adds or changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I verified that my code applies to the guidelines (composer code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai (see license)

This PR aims to add feature requested in #4525

@chinmaypurav chinmaypurav marked this pull request as draft January 14, 2024 11:59
@chinmaypurav
Copy link
Author

I know there is a request for some additional formats related to counter and per user counter, but I am planning that to cover in another PR. I did not want to hold this one out as that feature would take a while to develop.

Copy link
Member

@kevinpapst kevinpapst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check my comments please.

src/Invoice/Calculator/FinancialYearCalculator.php Outdated Show resolved Hide resolved
src/Invoice/Calculator/FinancialYearCalculator.php Outdated Show resolved Hide resolved
src/Invoice/Calculator/FinancialYearCalculator.php Outdated Show resolved Hide resolved
src/Invoice/Calculator/FinancialYearCalculator.php Outdated Show resolved Hide resolved
src/Invoice/Calculator/FinancialYearCalculator.php Outdated Show resolved Hide resolved
src/Invoice/Calculator/FinancialYearCalculator.php Outdated Show resolved Hide resolved
src/Invoice/Calculator/FinancialYearCalculator.php Outdated Show resolved Hide resolved
@chinmaypurav
Copy link
Author

Can you check my comments please.

Can you check it once?

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ Chinmay Purav
❌ chinmaypurav


Chinmay Purav seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants