Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unclear Docker volume binds for Demo #21

Open
rcopstein opened this issue Apr 29, 2022 · 2 comments
Open

Unclear Docker volume binds for Demo #21

rcopstein opened this issue Apr 29, 2022 · 2 comments

Comments

@rcopstein
Copy link

When running the Demo code on Docker, it took me a while before noticing that I needed to bind both $PWD/data and $PWD/temp (if I want the raw scores) when running the container. I would suggest adding a section to the README about executing the Demo on Docker and include something like the following snippet:

docker run -it \
	--rm \
	--name midas \
	--volume $PWD/data:/MIDAS/data \
	--volume $PWD/temp:/MIDAS/temp \
	midas

Any thoughts?
@liurui39660
Copy link
Member

Thanks for the suggestion, I think it should be fine to add such a section. Just I may need some time to test how it works (I'm not quite familiar with Docker). I'll close this issue once it's finished.

@rcopstein
Copy link
Author

Sounds good! Take your time.

The line like --volume $PWD/data:/MIDAS/data \ just tells the container that the folder located in /MIDAS/data (path after the colon) should mirror the contents of $PWD/data in the local filesystem. That makes all the dataset files available inside of the container for the demo to run.

In the case of $PWD/temp, we don't really have any content in there, but when the demo writes to it inside the container, Docker will mirror the contents back to the local filesystem, making it available even after the container exits.

Hope this helps :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rcopstein @liurui39660