http: fix nul deref on memcap reached #11098
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HttpRangeOpenFileAux may return NULL in different cases, including when memcap is reached. But is only caller did not check it before calling HttpRangeAppendData which would dereference the NULL value. Ticket: 7029
|
This is a shame that this was not found by any static code analysis tool. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11098 +/- ##
==========================================
+ Coverage 84.08% 84.10% +0.01%
==========================================
Files 925 925
Lines 250562 250563 +1
==========================================
+ Hits 210687 210725 +38
+ Misses 39875 39838 -37
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 20663 |
victorjulien
approved these changes
May 17, 2024
Merged
|
Merged in #11112, thanks! |
This was referenced May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7029
Describe changes: