Unused parameters v2 #11097
Closed
Unused parameters v2 #11097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and remove empty line before end of function
5ecd037
to
8b5421d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11097 +/- ##
==========================================
- Coverage 84.08% 79.04% -5.05%
==========================================
Files 925 925
Lines 250562 250269 -293
==========================================
- Hits 210687 197813 -12874
- Misses 39875 52456 +12581
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
ERROR: ERROR: QA failed on build_asan. Pipeline 20664 |
|
Information: QA ran without warnings. Pipeline 20673 |
|
Not sure I should keep this on... |
Would like to see this get merged. Can you rebase and do a new PR? |
|
Will do |
Closed
|
Rebased in #11155 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
None, generic cleanup
Describe changes:
return;line at the end of a functionContinuation of #11080