Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next/qarebaseline/20240504/v1 #11021

Closed
wants to merge 5 commits into from
Closed

next/qarebaseline/20240504/v1 #11021

wants to merge 5 commits into from

Conversation

catenacyber
Copy link
Contributor

@catenacyber catenacyber added the needs baseline update QA will need a new base line label May 4, 2024
@catenacyber catenacyber mentioned this pull request May 4, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented May 4, 2024 •
edited

Codecov Report

Attention: Patch coverage is 77.14286% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 83.60%. Comparing base (f14a4a1) to head (173cbaf).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #11021      +/-   ##
==========================================
+ Coverage   80.66%   83.60%   +2.94%     
==========================================
  Files         923      923              
  Lines      250204   250419     +215     
==========================================
+ Hits       201833   209375    +7542     
+ Misses      48371    41044    -7327
Flag Coverage Δ
fuzzcorpus 64.20% <74.28%> (-0.11%) ⬇️
livemode 18.42% <31.42%> (+<0.01%) ⬆️
suricata-verify 62.75% <71.42%> (?)
unittests 62.32% <31.42%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information:

ERROR: QA failed on SURI_TLPW1_files_sha256.

ERROR: QA failed on SURI_TLPR1_alerts_cmp.

ERROR: QA failed on IPS_AFP_drop_chk.

field baseline test %
SURI_TLPW1_stats_chk
.app_layer.flow.ftp 52 43 82.69%
.app_layer.tx.ftp 819 188 22.95%
.app_layer.error.ftp.gap 2 0 -
.app_layer.error.ftp.parser 2 0 -
.ftp.memuse 348 3 0.86%
SURI_TLPR1_stats_chk
.ftp.memuse 11385 10637 93.43%
IPS_AFP_stats_chk
.ips.blocked 1395360 747360 53.56%
.ips.drop_reason.flow_drop 1296000 680400 52.5%
.ips.drop_reason.applayer_error 32400 0 -
.flow.end.state.established 583199 550799 94.44%
.flow.end.state.closed 1016272 1048672 103.19%
.flow.end.tcp_state.established 201960 169560 83.96%
.flow.end.tcp_state.closed 1016272 1048672 103.19%
.app_layer.error.exception_policy.drop_flow 32400 0 -
.app_layer.error.ftp.parser 32400 0 -
.app_layer.flow.ftp 33480 1080 3.23%
.app_layer.tx.ftp 131760 2160 1.64%
TREX_GENERIC_stats_chk
.app_layer.flow.ftp 14871 0 -
.app_layer.tx.ftp 59484 0 -
.app_layer.error.ftp.parser 14871 0 -

Pipeline 20503

@victorjulien
Copy link
Member

@ct0br0 can you prep a rebaseline based on this PR?

@victorjulien victorjulien added this to the 8.0 milestone May 16, 2024
@victorjulien victorjulien mentioned this pull request May 16, 2024
Merged
@victorjulien
Copy link
Member

Merged in #11095, thanks!

@catenacyber catenacyber mentioned this pull request May 20, 2024
Closed
@catenacyber
Copy link
Contributor Author

Forgot to do a staging SV PR matching this cf https://github.com/OISF/suricata-verify/labels/tests%20pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorjulien victorjulien victorjulien approved these changes

@jufajardini jufajardini Awaiting requested review from jufajardini jufajardini is a code owner

Assignees
No one assigned
Labels
needs baseline update QA will need a new base line
Milestone
8.0
3 participants
@catenacyber @suricata-qa @victorjulien