Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 5.2: New pipeline functions remove_single_field and remove_multiple_fields #19300

Merged
merged 3 commits into from
Jun 5, 2024
Merged

Backport 5.2: New pipeline functions remove_single_field and remove_multiple_fields #19300

merged 3 commits into from
Jun 5, 2024

Conversation

patrickmann
Copy link
Contributor

@patrickmann patrickmann commented May 8, 2024 •
edited

5.2 backport of #19268

  • new pipeline functions remove_single_field and remove_multiple_fields

  • CL

  • improve rulebuilder descriptions

  • compile regex and other feedback changes

  • pre-compile pattern

  • UI string improvements

(cherry picked from commit 4a1cbb4)

patrickmann and others added 2 commits May 8, 2024 16:57
@patrickmann
New pipeline functions remove_single_field and `remove_multiple_fie…
46d3020 
…lds` (#19268)

* new pipeline functions remove_single_field and remove_multiple_fields

* CL

* improve rulebuilder descriptions

* compile regex and other feedback changes

* pre-compile pattern

* UI string improvements

(cherry picked from commit 4a1cbb4)
@patrickmann
adjust unit test for 5.2
e9a6aab
@patrickmann patrickmann marked this pull request as ready for review May 8, 2024 16:11
@patrickmann patrickmann changed the title New pipeline functions remove_single_field and remove_multiple_fields Backport 5.2: New pipeline functions remove_single_field and remove_multiple_fields May 8, 2024
@patrickmann patrickmann requested a review from a team May 8, 2024 16:13
@patrickmann patrickmann modified the milestone: 6.0.1 May 8, 2024
@kodjo-anipah kodjo-anipah self-requested a review June 4, 2024 12:40
kodjo-anipah
kodjo-anipah reviewed Jun 5, 2024
View reviewed changes
changelog/unreleased/issue-19098.toml Outdated
"""

issues=["19098"]
pulls=["19268"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GL 5.2 and the pulls=["19300"]

kodjo-anipah
kodjo-anipah approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@kodjo-anipah kodjo-anipah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patrickmann patrickmann merged commit 3906ce2 into 5.2 Jun 5, 2024
5 checks passed
@patrickmann patrickmann deleted the remove_fields52 branch June 5, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kodjo-anipah kodjo-anipah kodjo-anipah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@patrickmann @kodjo-anipah