Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENHANCEMENT] Captcha cache in Redis (maybe even stats in Redis?) #8

Open
realkarmakun opened this issue Apr 18, 2022 · 4 comments
Open

[ENHANCEMENT] Captcha cache in Redis (maybe even stats in Redis?) #8

realkarmakun opened this issue Apr 18, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@realkarmakun
Copy link

realkarmakun commented Apr 18, 2022 •
edited

Describe the feature you'd like to have implemented
It would be nice to have a command or Java code API means to enable "protection" on a server.

Is your feature request related to an existing problem? Please describe.
Right now I have around 8 velocity instances. Using filter-toggle options is not really beneficial since under normal loads we have 8 Connections per second to frontend, and less than 1 connection per second on each instance. I could setup it in a way to be enabled on a slightest load change but our project has a "wipe every n days" kind of gameplay. So essentially players log in all at once one time in two weeks or so. Enabling captcha at this time is undesirable.

I am aware of /bf reload command, but I just don't want to redact configs on all 8 instances :9

Additional context
Command would be enough for me personally and there is no need for full featured API.
@realkarmakun realkarmakun added the enhancement New feature or request label Apr 18, 2022
@realkarmakun
Copy link
Author

Would probably make sense not to save switch status between restarts and default it to disabled. If user can restart the server he might as well change config file to fit his needs.

@realkarmakun
Copy link
Author

realkarmakun commented Apr 18, 2022 •
edited

After further research I came to conclusion that my math was wrong, and CPS on instances can be either much higher or much lower. This could be solved other way around by delegating statistics to database of some sorts (redis sync in LibmoFilter Pog) and acting upon unified stats. Though run time means to enable/disable still would be nice.

@realkarmakun
Copy link
Author

realkarmakun commented Jun 26, 2022 •
edited

@hevav Кеш капчи в редисе чтобы облегчить жизнь мультиинстансам? Было бы мило иметь стату там же, но это второстепенно (учитывая формат хранения статистики не уверен что редис подойдет)

Пингую, потому что никто не отвечает :(

@realkarmakun realkarmakun changed the title [ENHANCEMENT] Runtime check-state and check-state-non-toggled switch [ENHANCEMENT] Captcha cache in Redis (maybe even stats in Redis?) Jun 26, 2022
@hevav
Copy link
Member

hevav commented Jun 26, 2022

Редис подойдет в этом случае
Видел эту идею в дискорде
Будет реализовано

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hevav @realkarmakun